-
Notifications
You must be signed in to change notification settings - Fork 36
read the docs deployment preview #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
read the docs deployment preview #361
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
7d1744e
to
58148cd
Compare
3097459
to
2b7414a
Compare
@vgvassilev @SylvainCorlay @anutosh491 I couldn't get the auto commenter to work as I wanted from a fork. Apparently its the way Github is designed for security concerns. But once this PR is in, and the readthedocs workflow has finished for a particular PR, you can preview the xeus-cpp deployment for that PR by going to https://xeus-cpp--${PR-number}.org.readthedocs.build/en/${PR-number}/xeus-cpp/lab/index.html (obviously replacing ${PR-number} with the PR number of the PR). In this case it would be https://xeus-cpp--361.org.readthedocs.build/en/361/xeus-cpp/lab/index.html This PR is ready for review. |
So there is no way we could get the deployment through a bot ? I see almost every other jupyterlite/jupyter repo having it, so I don't think its not achievable overall. |
@vgvassilev @anutosh491 What do you mean by add a deployment through a bot? The deployment is being built through read the docs runners just like other jupyter repos. If your on about a bot to provide the comment which gives you the link to the deployment, then I tried Jupyter lites workflow for that, and it didn't work. It basically says it doesn't have access to the necessary secrets if I remember correct for forks to be able to comment. Its possible that if you merge the workflow, then it gains the necessary permissions to comment, like the git clang tidy workflow needs, but I have no way to prove that. |
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.